apol added a comment.

  This will always have this environment variable set up, which could become a 
bit weird if we end up supporting changing shells, because we'd have a value in 
the environment variable but the shell in another.
  How about passing it through a file?

INLINE COMMENTS

> main.cpp:91
>  
> +    QString defaultShell = qgetenv("KDE_PLASMA_SHELLPACKAGE");
> +    if (defaultShell.isEmpty()) {

qEnvironmentVariable

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23023

To: mart, #plasma
Cc: apol, bshah, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

Reply via email to