iasensio created this revision. iasensio added reviewers: ngraham, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. iasensio requested review of this revision.
REVISION SUMMARY When typing a conversion, and the second unit is partially written (i.e. "10€ to ru..." the results are duplicated by several times. This behavior happens with different categories of units (lenght, currency, ...) and on different languages. The problem is that a new result is being added not once for every matching unit, but once for every matching stringUnit, generating the duplicates. Before: F7202568: krunner_before.png <https://phabricator.kde.org/F7202568> After: F7202571: krunner_after.png <https://phabricator.kde.org/F7202571> This is my first attempt to build kde from source and commit the diff to phabricator, so please excuse any possible mistakes. BUG: 410744 TEST PLAN Open krunner and type any conversion with a letter for the second unit: "10€ to r" Result for each matching second unit is only shown one time REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D23064 AFFECTED FILES runners/converter/converterrunner.cpp To: iasensio, ngraham, broulik Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
