davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  It was first added in 2d5f289767ee7b7c54f8b55e8032d20ef7f092f4 
<https://phabricator.kde.org/R119:2d5f289767ee7b7c54f8b55e8032d20ef7f092f4> 
with some pretty sparse docs, then copy pasted all over the place.
  
  It does appear to be no longer needed.
  
  I suspect https://codereview.qt-project.org/c/qt/qtbase/+/139775 fixes it 
which was back in 5.6
  
  If we remove here, please can we also do
  
  kcms/desktoptheme/kcm.cpp:    
qApp->setAttribute(Qt::AA_DontCreateNativeWidgetSiblings);
  kcms/fonts/fonts.cpp:    
qApp->setAttribute(Qt::AA_DontCreateNativeWidgetSiblings);
  kcms/lookandfeel/kcm.cpp:    
qApp->setAttribute(Qt::AA_DontCreateNativeWidgetSiblings);
  
  in p-d

REPOSITORY
  R102 KInfoCenter

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22012

To: meven, mart, #plasma, davidedmundson
Cc: davidedmundson, ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

Reply via email to