broulik added inline comments. INLINE COMMENTS
> fvogt wrote in content-script.js:837 > Where is that documented? https://w3c.github.io/web-share/#security-and-privacy-considerations > 4. Security and privacy considerations > > […] > > *Due to the capabilities of the API surface, navigator.share() is available > only in secure contexts (such as https:// schemes). > fvogt wrote in purposeplugin.cpp:86 > Now we have `error`, `errorCode` and `errorMessage`? `errorCode` and `errorMessage` are forwarded from the Purpose plugin, `error` is our own. I could change `errorCode` to return a string from us then I guess. Or I hardcode a magic 1 here which is `ERR_USER_CANCELED` which Purpose uses when canceled but that won't help for the busy case? > fvogt wrote in purposeplugin.cpp:153 > 0 is a valid serial... :) REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D23151 To: broulik, #plasma, fvogt, davidedmundson, nicolasfella, apol Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
