broulik added a comment.
Working very nice now! Just some minor nitpicks then this can go in INLINE COMMENTS > SidebarMode.h:54 > Q_PROPERTY(int width READ width NOTIFY widthChanged) > + Q_PROPERTY(bool actionMenuVisible READ actionMenuVisible WRITE > setActionMenuVisible NOTIFY actionMenuVisibleChanged) > Doesn't need a `WRITE` as it is internal > SidebarMode.h:77 > + bool actionMenuVisible() const; > + void setActionMenuVisible(const bool &actionMenuVisible); > + Make the setter `private` > SidebarMode.h:107 > Private *const d; > + bool m_actionMenuVisible = false; > }; Move this to the `Private` class REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D22896 To: GB_2, #plasma, #vdg, ngraham, mart Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
