davidedmundson added inline comments. INLINE COMMENTS
> gikari wrote in CMakeLists.txt:20 > Xml comes from gtk configuration daemon I'm currently working on, whose > source code is currently here <https://gitlab.com/gikari/kde-gtk-configd>. > But it was recomended to me to make the daemon as the patch to either > plasma-desktop, plasma-workspace or kde-gtk-config repos. > > If I understand correctly, this is not a correct way to import dbus > interface, but unfortunately I don't know how to do it properly. I tried what > I learned from the wiki tutorial about dbus (which is rather old by the way). > This is CMake code from the repo above to generate xml for development. > > set(DBUS_PREFIX "~/kde/usr/share/dbus-1/interfaces") > > set(SOURCES "kdegtkconfigd.cpp" > ${CMAKE_CURRENT_BINARY_DIR}/org.kde.gtkConfigd.xml) > set(HEADERS "kdegtkconfigd.h") > > qt5_generate_dbus_interface(kdegtkconfigd.h org.kde.gtkConfigd.xml OPTIONS > -A) > > qt5_add_dbus_adaptor(SOURCES org.kde.gtkConfigd.xml > kdegtkconfigd.h KdeGtkConfigd) > > install( > FILES ${CMAKE_CURRENT_BINARY_DIR}/org.kde.gtkConfigd.xml > DESTINATION ${DBUS_PREFIX} > ) If you put that daemon in plasma-desktop, then you can just do qt5_add_dbus_interface("../somePath.xml") here and my comment becomes a non-issue. If it ends up in gtk-config for separation, then we should continue that separation and just include the .xml file in two places. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21860 To: gikari, #plasma, apol, davidedmundson Cc: davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
