davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > recentusagemodel.cpp:98 > - > - return (service && (!favoritesModel || > !favoritesModel->isFavorite(service->storageId()))); > - } This is doing two things. 1. It's removing any favourite in the history that returns a defunct service. i.e if dolphin is a favourite and you uninstall dolphin it will go away. 2. removing duplicates from the favourites model. We definitely still want 1. 2 definitely makes sense to be optional, even off by default, but simply removing it will change kicker. Is there a reason to change kicker? If not, it needs to be a property. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23461 To: tcanabrava, hein, davidedmundson Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
