ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
I would remove the big text block from the form layout, since this makes it
look off-center. Also it needs a bigger margin below it. See also the following
inline comments:
INLINE COMMENTS
> main.qml:68
> + modeOptions.append({text: i18n("Detailed System
> Information"), value: UserFeedback.Provider.DetailedSystemInformation})
> + modeOptions.append({text: i18n("Detailed Usage
> Information"), value: UserFeedback.Provider.DetailedUsageStatistics})
> +
These strings still need to be re-worded, and possibly collapsed, and possible
the whole UI needs to be re-thought. What if I want to submit detailed system
information but only basic usage information? Maybe we need two combo boxes,
one for system info and one for usage info.
> main.qml:89
> +
> + QQC2.Label {
> + Layout.maximumWidth: root.width * 0.5
This label never shows up for me, no matter which entry is selected in the
combo box.
> ngraham wrote in main.qml:41
> 1. Since this is no longer just about Plasma, maybe the first sentence should
> say, "We make software for you".
>
> 2. Use kuit formatting for newlines: `xi18nc("@info", "Line 1<nl/>Line
> 2<nl/>Line 3<nl/>etc.");`
#1 isn't done yet (it still talks about Plasma, not KDE software more generally)
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D24011
To: apol, #plasma, vkrause, ngraham
Cc: aspotashev, ngraham, bcooksley, davidedmundson, ognarb, broulik,
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
