cblack added a comment.

  In D24324#541215 <https://phabricator.kde.org/D24324#541215>, @ndavis wrote:
  
  > In D24324#541214 <https://phabricator.kde.org/D24324#541214>, @cblack wrote:
  >
  > > In D24324#541212 <https://phabricator.kde.org/D24324#541212>, @ndavis 
wrote:
  > >
  > > > I'm not sure how to verify if the assets have been generated correctly. 
What GTK2 programs did you test with?
  > >
  > >
  > > Look for a theme in `~/.local/share/themes` called `Breeze 🎨`. The reason 
why it has a 🎨 is to distinguish it from the system Breeze GTK2 theme. 
Otherwise,
  > >  there'd be two Breeze entries listed in the user's GTK2 theme list in 
syse5. Yes, it's clunky, but this is a toolkit older than me, so clunkiness is 
expected.
  > >
  > > I would probably add a "if the user has GTK2 theme set to Breeze/Breeze 
Dark change the GTK2 theme to the recoloured one" but I'm not sure
  > >  what direction GTK configuration is heading with that configuration 
daemon being worked on, so I'd rather not mess with GTK configuration until 
that's ironed out.
  >
  >
  > Am I supposed to run this script myself? I did `make install` and it didn't 
seem to do anything.
  >
  > Are you sure the emoji isn't going to be a problem in programs or systems 
with no emoji fonts?
  
  
  Eh, if you have any better ideas for the name let me know.
  
  As for testing it, you need both this revision and the one I marked it as 
dependent on. The colors KCM should run the script whenever you apply a 
colorscheme.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24324

To: cblack, #breeze
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to