broulik added inline comments.

INLINE COMMENTS

> Output.qml:272
> +        cursorShape: Qt.OpenHandCursor
> +        acceptedButtons: Qt.NoButton // Otherwise it interferes with the 
> drag handler
> +        visible: kcm.outputModel && kcm.outputModel.rowCount() > 1

Hm, can you still make the hand "close" when you press the button, which is 
what is typically done for dragging things

> Output.qml:273
> +        acceptedButtons: Qt.NoButton // Otherwise it interferes with the 
> drag handler
> +        visible: kcm.outputModel && kcm.outputModel.rowCount() > 1
> +    }

That won't update when outputs are added/removed, an invokable cannot be 
signalled

> Screen.qml:59
> +        }
> +        text: "Drag screens to re-arrange them"
> +        visible: kcm.outputModel && kcm.outputModel.rowCount() > 1

`i18n`

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24479

To: ngraham, romangg, #plasma, #vdg
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to