davidedmundson added inline comments. INLINE COMMENTS
> CMakeLists.txt:22 > set(kcm_cursortheme_PART_SRCS kcmcursortheme.cpp ${libnoinst_SRCS}) > - > +kconfig_add_kcfg_files(kcm_cursortheme_PART_SRCS cursorthemesettings.kcfgc > GENERATE_MOC) > add_library(kcm_cursortheme MODULE ${kcm_cursortheme_PART_SRCS}) Can you also add install(FILES kded/touchpaddaemon.kcfg DESTINATION ${KDE_INSTALL_KCFGDIR}) This doesn't explicitly do anything useful, but it allows future metadata extraction for documentation purposes. > kcmcursortheme.cpp:72 > + // Unfortunately doesn't generate a ctor taking the parent as parameter > + m_settings->setParent(this); > qmlRegisterType<PreviewWidget>("org.kde.private.kcm_cursortheme", 1, 0, > "PreviewWidget"); I assume Kevin's patch set fixes this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24517 To: bport, #plasma, mart, ervin Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart