ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed.
Overall this doesn't look like the proper fix to me. A setter should not do anything if we pass the current value to it. From your description it seems to indicate that a call to setTheme is missing in some situations, I think it'd lead to a better fix if the exact condition when this happens is determined and then the extra setTheme call inserted just then. Changing a setter semantic to get a side-effect looks wrong to me. INLINE COMMENTS > previewwidget.h:34 > Q_PROPERTY(int currentIndex READ currentIndex WRITE setCurrentIndex > NOTIFY currentIndexChanged) > - Q_PROPERTY(int currentSize READ currentSize WRITE setCurrentSize NOTIFY > currentSizeChanged) > + Q_PROPERTY(int currentSize WRITE setCurrentSize) > I'd keep it as is for the reasons I mentioned in another patch: avoid write only properties, it's really annoying on the QML side. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24520 To: bport, #plasma, mart, ervin, davidedmundson Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
