bport added subscribers: ervin, bport.
bport added inline comments.

INLINE COMMENTS

> kcmaccess.h:32-67
> +    Q_PROPERTY(int timeoutDelay          READ timeoutDelay              
> WRITE setTimeoutDelay            NOTIFY timeoutDelayChanged)
> +    Q_PROPERTY(int bounceKeysDelay       READ bounceKeysDelay           
> WRITE setBounceKeysDelay         NOTIFY bounceKeysDelayChanged)
> +    Q_PROPERTY(int duration              READ duration                  
> WRITE setDuration                NOTIFY durationChanged)
> +    Q_PROPERTY(int slowKeysDelay         READ slowKeysDelay             
> WRITE setSlowKeysDelay           NOTIFY slowKeysDelayChanged)
> +    Q_PROPERTY(int mouseKeyDelay         READ mouseKeyDelay             
> WRITE setMouseKeyDelay           NOTIFY mouseKeyDelayChanged)
> +    Q_PROPERTY(int mouseKeyInterval      READ mouseKeyInterval          
> WRITE setMouseKeyInterval        NOTIFY mouseKeyIntervalChanged)
> +    Q_PROPERTY(int mouseKeyTimeToMax     READ mouseKeyTimeToMax        WRITE 
> setMouseKeyTimeToMax       NOTIFY mouseKeyTimeToMaxChanged)

Using KConfigXT will remove lots of boilerplate code (tons of property 
declaration + associated methods and easiest, load, save and defaults method).
 And with the work done by @ervin on KConfigXT and KQuickAddons::ConfigModule 
you will have benefits (defaults, reset, apply button state for example will be 
handled automatically)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24224

To: tcanabrava, ngraham
Cc: bport, ervin, mart, ngraham, whiting, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

Reply via email to