broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision.
REVISION SUMMARY Since Qt 5.12.5 and newer this causes infinite recursion in component creation as setting the `model` has `ListView` recreate its header item (among other things) since https://code.qt.io/cgit/qt/qtdeclarative.git/commit/?h=5.12&id=692b2da77427259a3589cf8a1311075863f2f5ec See also https://bugzilla.redhat.com/show_bug.cgi?id=1758263 TEST PLAN 5.12 only - Notifications work again and don't crash* - Turning on and off history works - Turning on and off notifications works I failed to reproduce in a simple test case for submitting a bug report. I tried having a `ListView` with a `header` that sets the `model` and `delegate` but all I could get was "Cannot create new component instance before completing the previous" but none of the recursion havoc or aborting component creation as in the notification applet :( REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24654 AFFECTED FILES applets/notifications/package/contents/ui/Notifications.qml applets/notifications/package/contents/ui/main.qml To: broulik, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
