romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land.
In D24834#551507 <https://phabricator.kde.org/D24834#551507>, @ngraham wrote: > In D24834#551506 <https://phabricator.kde.org/D24834#551506>, @romangg wrote: > > > Looks good. If the display is too small to display two rows or the name is even longer, does it just elide? > > > Yep. > > > One question I have long term is what information actually needs to be in there. Currently we have name and the logical size. Would only the name or name + resolution make more sense? > > Unless I'm misunderstanding things, it's already is showing the name and the resolution. The name is mandatory I think; not so sure about the resolution. It shows the logical size. If you have a 3840x2160 resolution screen with scale factor 2, it shows 1920x1080. I guess it's this way only on Wayland In D24834#551510 <https://phabricator.kde.org/D24834#551510>, @ngraham wrote: > You good with getting this into 5.17 now, and we can investigate what should be displayed in there for 5.18? Yes, 5.17. REPOSITORY R104 KScreen BRANCH more-text-in-visualizations (branched from Plasma/5.17) REVISION DETAIL https://phabricator.kde.org/D24834 To: ngraham, romangg, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
