ngraham added a comment.
In D24838#551712 <https://phabricator.kde.org/D24838#551712>, @zzag wrote: > Uh, I don't use Ukrainian locale. However, it doesn't matter that much. We format numbers practically the same way as in en_US. > > Given the current implementation of textFromValue and the fact that the maximum value of transTimeField is capped, this change is good to go. However, it would be great to respect the user's locale. I agree. Since there are other `textFromValue` implementations in plasma-desktop that don't do this, it would probably make sense to do them all at once. I'll see if I can figure out how. REPOSITORY R119 Plasma Desktop BRANCH valuefromtext (branched from master) REVISION DETAIL https://phabricator.kde.org/D24838 To: ngraham, #plasma, zzag Cc: zzag, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart