broulik added inline comments.

INLINE COMMENTS

> menu.cpp:146
> +                // Only show "Unlock Widgets" in the UI, not "Lock Widgets"
> +                if (!(name == QLatin1String("lock widgets") && 
> c->corona()->immutability() == Plasma::Types::Mutable)) {
> +                    actions << a;

Please avoid negating entire boolean statements.

Instead of `!(foo && bar)` use `!foo || !bar`

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D24839

REVISION DETAIL
  https://phabricator.kde.org/D24839

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: broulik, mart, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

Reply via email to