sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision.
REVISION SUMMARY this actually improves UX more than anything. when there was an update it is fairly impossible to install debug symbols, so drkonqi may get stuck in a loop between saying this crash is garbage and suggesting the user install some more symbols. what's more is that the crash can be the result of incompatibilities in runtime-loaded plugins (a notorious example are KIO slaves, which get forked from klauncher which I think can lead to problems when loading the newer libQt5Core.so etc.). all in all crashes coming from a half-update runtime are hard to trace and also at risk of being worthless. so, instead disable the report and the install symbols features and inform the user about what went wrong in both cases. this is pretty much exclusively working for linux where the kernel will actually add " (deleted)" hints to all symlinks in procfs and have a map_files directory where all mmap'd regions are symlinked to their respective paths... also with that suffix as needed. the way it works is super easy: iter all map_files, get all deleted paths, make sure none of the .so or the executable itself are marked deleted. if anything is marked deleted, the report feature gets disabled TEST PLAN update dolphin -> attach drkonqi -> drkonqi whines about dolphin being updated REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D25002 AFFECTED FILES src/backtracewidget.cpp src/crashedapplication.cpp src/crashedapplication.h src/drkonqibackends.cpp src/drkonqidialog.cpp To: sitter, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
