filipf added a subscriber: davidedmundson.
filipf added a comment.

  @davidedmundson I believe you wrote the code for the the avatar size in the 
lock and login screens (`property real faceSize: Math.min(width, height - 
usernameDelegate.height - units.smallSpacing`).
  
  Is it alright to replace it with `units.gridUnit * 7`?
  
  I tested with several screen resolutions and I can't find any issues, but new 
code is simpler than old code so I wonder if there's something I'm missing.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25024

To: filipf, #plasma, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to