broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision.
REVISION SUMMARY I've seen people complaining about ugly notification popups when they were in fact running Dunst instead of Plasma. Since the KCM won't work with notifications other than Plasma's, this patch adds a hint informing the user when there is no notification widget or notifications are provided by another service than Plasma. Notification API provides a way to query server identity which is used to determine if it's Plasma or not. The process name isn't used as you could have a notifications widget in e.g. Latte Dock. TEST PLAN Actually the notification service isn't running/registered but from a user's POV they might just not have a notification widget. F7703382: Screenshot_20191031_174724.png <https://phabricator.kde.org/F7703382> Service owned by someone else F7703383: Screenshot_20191031_174732.png <https://phabricator.kde.org/F7703383> REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25097 AFFECTED FILES kcms/notifications/CMakeLists.txt kcms/notifications/kcm.cpp kcms/notifications/kcm.h kcms/notifications/package/contents/ui/main.qml To: broulik, #plasma, #vdg Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
