jbbgameich added inline comments.

INLINE COMMENTS

> mart wrote in FormLayout.qml:277
> fontmetrics is the default font height, and this being an heading may be more 
> (when is heading)
> does it work if instead you do here
> return implicitHeight  ?

It works but produces a slightly smaller margin. But it looks good as well so 
I'll update the diff.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25175

To: jbbgameich, #kirigami, #plasma:_mobile
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, hein

Reply via email to