ahiemstra marked 3 inline comments as done. ahiemstra added inline comments.
INLINE COMMENTS > leinir wrote in Action.qml:124 > You're right, NoPreference would probably be more linguistically correct... i > was more thinking along the lines of, if the default means there is no > preferred hint, then NoHint would be it... either would be fine for me, > though :) I have added a NoPreference value which is now the default and documented as such. I went with the NoPreference suggestion since that makes it more clear when overriding displayHint in other places. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25176 To: ahiemstra, #kirigami Cc: broulik, leinir, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein