broulik added inline comments. INLINE COMMENTS
> columnview.cpp:51 > + Q_ASSERT(engine); > + if(privateQmlComponentsPoolSelf->m_instances.contains(engine)) { > + return privateQmlComponentsPoolSelf->m_instances[engine]; Avoid double lookup: auto *componentPool = privateQmlComponentsPoolSelf->m_instances.value(engine); if (componentPool) { return componentPool; } componentPool = new QQmlComponentsPool(engine); ... return componentPool; REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25284 To: davidedmundson Cc: broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein