meven accepted this revision. meven added a comment. This revision is now accepted and ready to land.
Nice, I am properly not the best reviewer here, but it looks ok to me. INLINE COMMENTS > wifisecurity.cpp:118 > + } else if (securityIndex == SAE) { > + return !m_ui->psk->text().isEmpty() || m_ui->psk->passwordOption() > == PasswordField::AlwaysAsk; > } It is very similar with `securityIndex == WpaPsk) { // WPA` if `NetworkManager::wpaPskIsValid(m_ui->psk->text())` could be used instead of `!m_ui->psk->text().isEmpty()` we could use a single if block for both. As a side note this if block could become a `switch(securityIndex)` REPOSITORY R116 Plasma Network Management Applet BRANCH wpa3 REVISION DETAIL https://phabricator.kde.org/D24691 To: jgrulich, #plasma, meven Cc: meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart