broulik added inline comments.

INLINE COMMENTS

> server_p.cpp:93
>      if (!master) {
> -        connect(dbusIface, &QDBusConnectionInterface::serviceUnregistered, 
> this, [=](const QString &serviceName) {
> -            if (serviceName == notificationService) {
> -                qCDebug(NOTIFICATIONMANAGER) << "Lost ownership of" << 
> serviceName << "service";
> -                emit serviceOwnershipLost();
> -            }
> -        });
> +        connect(dbusIface, &QDBusConnectionInterface::serviceUnregistered, 
> this, &ServerPrivate::onInterfaceServiceUnregistered, Qt::UniqueConnection);
>      }

Just noticed I can probably reuse the inhibition service watcher rather than do 
a wildcard watch here?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25772

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to