broulik created this revision.
broulik added reviewers: Kirigami, Frameworks, kossebau, aacid.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The ECM QM Loader uses `Q_COREAPP_STARTUP_FUNCTION` which doesn't work for 
things loaded as plugins like QML modules.
  This copies the logic over to the plugin so the translations are loaded when 
the QML plugin is loaded.
  Not really like it, so I'm open to suggestions how to do that better in ECM 
or I don't know?

TEST PLAN
  - The Search field in Kirigami is translated now
  - The AboutPage in Kirigami is translated now

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

AFFECTED FILES
  src/kirigamiplugin.cpp
  src/kirigamiplugin.h

To: broulik, #kirigami, #frameworks, kossebau, aacid
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

Reply via email to