romangg added a comment.
In D25539#579054 <https://phabricator.kde.org/D25539#579054>, @ngraham wrote: > I'm torn. In principle I agree that this is a great improvement to help people avoid blowing themselves up while testing settings. However I'm not convinced that the patch's current form strikes the right balance between achieving that goal and not annoying the user by reverting their intended changes when not needed. > > In general I love InlineMeessages but I don't know if they're the right UI element here because they aren't modal. For this warning here I think we want a modal dialog because then the user can't miss it and get their settings reverted accidentally, which is possible with non-modal InlineMessages. I agree with your argument in the current setting but a modal dialog won't work with instant-apply and that's where the KScreen KCM will be heading (reason for that again is primarily to make it work well in Plasma mobile). REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D25539 To: liushuyu, #vdg, #plasma, romangg Cc: ngraham, broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
