davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed.
On the conceptual level, does it make more sense for the relevant client (konsole) to monitor for compositing changed itself. It's something that could change at runtime regardless, so it needs to react to it anyway? If it does need that code anyway, there's no point doing fixes in startkde ---- Code wise, this gives a timeout for anyone who doesn't run kwin composited, which would be a problem as is. also I don't like the split that ksmserver is waiting for kwin to register on ICE, and startkde is waiting on kwin through a combo of both DBus and X atoms in KWindowSystem::compositingActive(). That's 3 different paths all used at once. I've been wanting to move the kwin startup from ksmserver into startkde anyway, doing those things together would make the most sense. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26338 To: esjeon, #plasma, davidedmundson Cc: asturmlechner, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
