ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  The preview area from the current KCM is missing.
  
  In the sheet, the scrollview below the search field seems to be on top of the 
search field, and the sheet's close button is inside it: F7877467: 
Screenshot_20200111_095443.png <https://phabricator.kde.org/F7877467> We should 
use a more conventional approach of having an actual framed scrollview below a 
search field, with both vertically aligned to one another, and  with margins 
around all of them.
  
  In the sheet, the scrollbar scrolls the sheet itself, not the list inside it, 
and when you scroll in the list, the scrollbar doesn't change: F7877476: 
scrollbar.webm <https://phabricator.kde.org/F7877476>
  
  The scroll speed in the sheet is way too fast when using a touchpad.
  
  The Reset button doesn't do anything when clicked.
  
  The Defaults button doesn't do anything when clicked.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25449

To: tcanabrava, ervin, #vdg, #plasma, mart, ngraham
Cc: anthonyfieroni, mart, ngraham, broulik, ervin, davidedmundson, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra

Reply via email to