meven added inline comments.

INLINE COMMENTS

> componentchooserbrowser.cpp:79
>  {
> -    return radioKIO->isChecked();
> +    // no real default
> +    return true;

Do we want to set falkon or konqueror as default ?

> componentchooserbrowser.cpp:86
> -    if (exec.isEmpty()) {
> -        radioKIO->setChecked(true);
> -        m_browserExec = exec;

With the remove as this possible setting, we don't have a way to set things as 
they were.
But I don't this is an issue, the behavior encompassed here, is I believe 
already gone in KRun (where KRun would determine the http resource mimetype and 
launch the appropriate application accordingly).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26731

To: meven, ngraham, #plasma, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to