filipf requested changes to this revision. filipf added a comment. This revision now requires changes to proceed.
I think what Noah means is that the media controls row should perfectly touch the left, right and bottom border. The margins in this patch are too big so they effectively create another frame in a frame. But what's more important is that having the highlight effect above everything just doesn't work with themes that have a filled highlight style. We should scrap that idea. F7889878: Screenshot_20200118_120047.png <https://phabricator.kde.org/F7889878> REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26739 To: ngraham, #plasma, #vdg, filipf Cc: filipf, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
