sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision.
REVISION SUMMARY allDevice is bugging out and having duplicated entires https://bugs.kde.org/show_bug.cgi?id=416495 this results in garbage in our tree view. on top of that running through allDevices is entirely pointless as we can directly construct a Device from the udi we got which is not only faster, it also lets us bypass the aformentioned bug since the udi is still unique it's only the objects that get duped BUG: 399746 FIXED-IN: 5.18.0 TEST PLAN repated plug/unplug of usb drive doesn't cause bogus device entries REPOSITORY R102 KInfoCenter BRANCH devinfo-states REVISION DETAIL https://phabricator.kde.org/D26788 AFFECTED FILES Modules/devinfo/devicelisting.cpp To: sitter Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart