meven updated this revision to Diff 74304. meven marked 11 inline comments as done. meven added a comment.
- Make CfgPlugin a QComboBox with default and currently saved index handling - General code improvements : in loops, naming... - set the minimal width of combobox 18 making them most of the time of same lenght - Correct typo in license declaration REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26797?vs=74012&id=74304 BRANCH new-component-chooser REVISION DETAIL https://phabricator.kde.org/D26797 AFFECTED FILES kcms/componentchooser/CMakeLists.txt kcms/componentchooser/browserconfig_ui.ui kcms/componentchooser/componentchooser.cpp kcms/componentchooser/componentchooser.h kcms/componentchooser/componentchooser_ui.ui kcms/componentchooser/componentchooserbrowser.cpp kcms/componentchooser/componentchooserbrowser.h kcms/componentchooser/componentchooseremail.cpp kcms/componentchooser/componentchooseremail.h kcms/componentchooser/componentchooserfilemanager.cpp kcms/componentchooser/componentchooserfilemanager.h kcms/componentchooser/componentchooserterminal.cpp kcms/componentchooser/componentchooserterminal.h kcms/componentchooser/componentconfig_ui.ui kcms/componentchooser/emailclientconfig_ui.ui kcms/componentchooser/filemanagerconfig_ui.ui kcms/componentchooser/kcm_componentchooser.cpp kcms/componentchooser/kcm_componentchooser.h kcms/componentchooser/terminalemulatorconfig_ui.ui To: meven, #plasma, #vdg, ngraham, ervin Cc: filipf, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart