sitter added inline comments.
INLINE COMMENTS
> context.cpp:600
>
> +void Context::loadModule(const QString &name, const QString &argument)
> +{
Should this maybe return a bool? If the operation as a whole fails it seems
that should be reflected somehow. Or does this emit an error via event
subscription?
> context.cpp:607
> + const QByteArray argumentData = argument.toUtf8();
> + if (!PAOperation(pa_context_load_module(d->m_context,
> nameData.constData(), argumentData.constData(), nullptr, nullptr))) {
> + qCWarning(PULSEAUDIOQT) << "pa_context_load_module failed";
https://doc.qt.io/qt-5/qtglobal.html#qUtf8Printable
> context.cpp:612
> +
> +void Context::unloadModule(const quint32 index)
> +{
As I've mentioned in private message, I'd do away with this. The only way you,
as client, get to the index is through the Module object, so you may as well
pass in the Module*, thus rendering the index variant moot from an object POV.
REPOSITORY
R994 Pulseaudio Qt Bindings
REVISION DETAIL
https://phabricator.kde.org/D26935
To: bshah, sitter, nicolasfella
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
