alex created this revision. alex added reviewers: davidedmundson, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision.
REVISION SUMMARY The config keys are now in a separate file, instead of having them at two places. Runner The duplicate call to reloadConfiguration has been removed and aliases/codes get validated. Additionally the match method has been simplified and the character is now copied to the clipboard when selected. KCM Validation of the add/delete buttons, error message now in GUI and deprecated methods removed. TEST PLAN Compile, test runner and test editing entries. Manually add alias(and no hex value) to ~/.config/krunnerrc and reload the kcm, error message should be shown. Before: https://phabricator.kde.org/F8075415 https://phabricator.kde.org/F8075416 After: https://phabricator.kde.org/F8075419 https://phabricator.kde.org/F8075420 https://phabricator.kde.org/F8075422 REPOSITORY R114 Plasma Addons BRANCH charrunner_improvements (branched from master) REVISION DETAIL https://phabricator.kde.org/D27096 AFFECTED FILES runners/characters/charrunner.cpp runners/characters/charrunner.h runners/characters/charrunner_config.cpp runners/characters/charrunner_config.h runners/characters/charrunner_config.ui runners/characters/config_keys.h To: alex, davidedmundson, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
