ovichiro added inline comments.

INLINE COMMENTS

> main.cpp:68
> +        aboutData = KAboutData(QStringLiteral("systemsettings"), 
> i18n("System Settings"), QLatin1String(PROJECT_VERSION), i18n("Central 
> configuration center by KDE."), KAboutLicense::GPL, i18n("(c) 2009, Ben 
> Cooksley"));
> +        aboutData.addAuthor(i18n("Ben Cooksley"), i18n("Maintainer"), 
> QStringLiteral("bcooks...@kde.org"));
> +        aboutData.addAuthor(i18n("Mathias Soeken"), i18n("Developer"), 
> QStringLiteral("msoe...@informatik.uni-bremen.de"));

The authors should maybe be moved outside if-else since they are the same for 
both branches.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D26895

To: mart, #plasma, davidedmundson
Cc: ovichiro, meven, davidedmundson, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

Reply via email to