mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  almost there, just two minor nitpicks

INLINE COMMENTS

> AbstractApplicationHeader.qml:24
>  import org.kde.kirigami 2.4
> -
> +import QtQuick.Controls 2.7 as Controls
>  

the maximum version you can import here is 2.4 as is the one released with qt 
5.11 for which we depend from

> AbstractApplicationHeader.qml:100
>  
> +
>      Item {

remove extra whitespace

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27212

To: camiloh, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

Reply via email to