Am Freitag 23 April 2010 21:08:34 schrieb Ingomar Wesp: > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3786/ > ----------------------------------------------------------- > > Review request for Plasma. > > > Summary > ------- > > This is my proposed patch for the refactored quicklaunch applet as > discussed in review request http://reviewboard.kde.org/r/3358/ and on the > ML a while ago. Sorry that it took so long... > > Summary of changes: > - Refactored the quicklaunch applet, so that the applet, > icon grid widget and icon grid layout are split into > separate classes all living in a newly created namespace. > > - Improved drag & drop behaviour (it is not possible to drop items > in the popup dialog) and drag & drop markers. > > - Icons are now moved to/from the dialog explicitly instead of > asking the user to specify the number of the icons that are > shown in the primary area. > > - Icon size is now determined automatically based on the > available space, hard-coded minimum and maximum bounds and > the number of rows (or columns) set by the user. This is done > in a custom layout that is no longer based on > QGraphicsGridLayout. > > - When all icons are removed from an icon area, a placeholder > icon is displayed. > > As this patch changes the configuration keys used, it also incorporates > code for migrating older config keys. > > Unfortunately, using svn diff with files that have been "svn move"d appears > to yield broken diffs, so the patch here does not reflect the history for > files that are based on renamed files (quicklaunch.*, quicklaunchicon.*), > but I'll make sure that the history is preserved when committing (if this > gets a "ship it", that is). For keeping the history we usually use svn copy and then change the files :) svn move only works with svn paths, not with local paths...
I will test & review the patch soon :) Thanks Lukas > > Please give it a spin and tell me what you think. > > > This addresses bugs 206382, 206912, 214463, 225011, and 233914. > https://bugs.kde.org/show_bug.cgi?id=206382 > https://bugs.kde.org/show_bug.cgi?id=206912 > https://bugs.kde.org/show_bug.cgi?id=214463 > https://bugs.kde.org/show_bug.cgi?id=225011 > https://bugs.kde.org/show_bug.cgi?id=233914 > > > Diffs > ----- > > > /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/CMakeLists > .txt 1117710 > /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/Quicklaunc > hLayout.h 1117710 > /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/Quicklaunc > hLayout.cpp 1117710 > /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/icongrid.h > PRE-CREATION > /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/icongrid.c > pp PRE-CREATION > /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/icongridla > yout.h PRE-CREATION > /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/icongridla > yout.cpp PRE-CREATION > /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/quicklaunc > h.h PRE-CREATION > /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/quicklaunc > h.cpp PRE-CREATION > /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/quicklaunc > hApplet.h 1117710 > /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/quicklaunc > hApplet.cpp 1117710 > /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/quicklaunc > hConfig.ui 1117710 > /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/quicklaunc > hIcon.h 1117710 > /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/quicklaunc > hIcon.cpp 1117710 > /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/quicklaunc > hicon.h PRE-CREATION > /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/quicklaunc > hicon.cpp PRE-CREATION > > Diff: http://reviewboard.kde.org/r/3786/diff > > > Testing > ------- > > > Thanks, > > Ingomar > > _______________________________________________ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
