ngraham added inline comments.

INLINE COMMENTS

> TrafficMonitor.qml:64
>              top: parent.top
> -            topMargin: units.gridUnit
> +            topMargin: Math.round(labels.labelHeight / 2)
>          }

We could probably just use a smaller predefined unit, like `largeSpacing`, 
instead of coming up with a semi-random-looking value derived from the label 
height

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27391

To: gvgeo, #plasma, #vdg, jgrulich
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to