filipf added inline comments.

INLINE COMMENTS

> sddmauthhelper.cpp:138
> +        QSharedPointer<KConfig> themeConfig = 
> openConfig(themeConfigLocation);
> +        
> themeConfig->group(QStringLiteral("Theme")).writeEntry(QStringLiteral("name"),
>  args[QStringLiteral("plasmaTheme")].toString());
> +        const char* themeConfigLocationConverted = 
> themeConfigLocation.toLocal8Bit().data();

do I need to do `themeConfig->sync`? It seems to work as intended without it, 
even when just updating the entry.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D27461

To: filipf, #plasma, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to