ervin added inline comments.

INLINE COMMENTS

> meven wrote in DeviceAutomounter.cpp:73
> Unfortunately this is not possible line 78 requires a non-const ref to volume.

const auto for volumes was possible though.

I wonder if it wouldn't have made sense to have a non const ref in the loop 
then. Would have avoided the (potential) copy and made clear this loop was 
modifying. Oh well.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27052

To: meven, broulik, ervin, #plasma
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to