davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
There's no need for this property stuff
We have:
view->setScreen()
(or ideally passed in the constructor, it's a lot faster)
and
view->screen()
and that has everything we need.
INLINE COMMENTS
> greeterapp.cpp:407
> +{
> + for(auto view : m_views) {
> + QScreen *screen = screenFromName(screens(),
> view->property(screenNameProperty).toString());
Why are we looping through things again. It's all overly complex.
We just need
void screenAddedImpl(QScreen *)
{
//everything here
}
then one place in the ctor,
for (screen, qApp->screens()) {
screenAddedImpl(screen);
}
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D26986
To: tcanabrava, graesslin, davidedmundson
Cc: zzag, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
apol, ahiemstra, mart
