mart added inline comments.

INLINE COMMENTS

> ExpandedRepresentation.qml:48
> +                fill: parent
> +                leftMargin: -dialog.margins.left
> +                topMargin: -dialog.margins.top

not in all places you will have access to a dialog. the magic correct values 
should come from the toparea margins itself done to go well with the 
correspoding background svg.

in the end, i would like to have this in a control... i kinda hope a standard 
toolBar control (will need some special casing when that style is running in 
plasma or an app in plasma mobile

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

Reply via email to