gikari marked 4 inline comments as done.
gikari added a comment.

  I have just tested a couple of fonts.
  
  1. I've only tested Monospaced font with Russian locale, so I do not know it 
other ones work. Qt just ignores style string and any style of Monospaced is 
just `Monospaced,  10` in the config.
  2. Seems like GTK2 works fine with fonts and most of them works (Ubuntu Light 
for example).
  3. GTK3 however have troubles with font styles and ignores what is after a 
comma. So that may be a GTK3 bug.
  
  All in all it seems like the patch does not introduce any regressions (for me 
at least). Behaves better, that what was before: localized font styles are just 
ignored in the process, so the patch fixes a bug, where fonts in GTK apps are 
totally wrong and set to default.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven, davidedmundson
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to