broulik added inline comments.

INLINE COMMENTS

> main.qml:223
> +                onActivated: {
>                      cA.modeStaged = currentIndex;
>                      calcNeedsSave();

Change this to `index` (which is the signal argument). There's no guarantee 
that `currentIndex` will be updated at this point (it wasn't a while ago)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27689

To: davidedmundson, #plasma, apol
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to