nicolasfella marked an inline comment as done. nicolasfella added inline comments.
INLINE COMMENTS > apol wrote in PageRowGlobalToolBarUI.qml:49 > Wouldn't it be easier to do: > > visible: !Kirigami.Settings.isMobile && applicationWindow().globalDrawer && > applicationWindow().globalDrawer.isMenu > > ? > > Otherwise we better check for the property with `"isMenu" in > applicationWindow().globalDrawer` The former gives `Unable to assign [undefined] to bool` REPOSITORY R169 Kirigami BRANCH fixkamoso REVISION DETAIL https://phabricator.kde.org/D27996 To: nicolasfella, #kirigami, mart, ngraham Cc: apol, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ahiemstra, davidedmundson, mart