----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3903/#review5497 -----------------------------------------------------------
If the complete theme is missing, then I'd say 'OK, use air' (aka default). The problem with defaulting the items from air instead of oxygen is back-compatibility. Before Air, most themes were made incomplete - not defining elements relying those will be loaded from oxygen (remember, most kde-look themes are dark). Intoduction of Air as /default/ broke most of those themes, and that is the reason why in the fallback mechanism elements of oxygen needed to go first. - Ivan On 2010-05-07 13:17:50, Will Stephenson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3903/ > ----------------------------------------------------------- > > (Updated 2010-05-07 13:17:50) > > > Review request for Plasma. > > > Summary > ------- > > If a user starts Plasma on a machine where the configured desktop theme is > not available, a fallback is used for each element. If the theme is > completely missing, default fallbacks, in order "oxygen" and "default" are > used. This means that Oxygen elements are used in preference to Air > elements. With common configurations, this results in black text on the > black/dark Oxygen elements, which is unusable. > > This patch removes oxygen from the fallbacks, leaving "default" (Air). Since > both oxygen and air are installed by kdebase-workspace they are equally > likely to be present. > > > Diffs > ----- > > trunk/KDE/kdelibs/plasma/theme.cpp 1123666 > > Diff: http://reviewboard.kde.org/r/3903/diff > > > Testing > ------- > > > Thanks, > > Will > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
