cblack added inline comments.

INLINE COMMENTS

> kmaterka wrote in ExpandedRepresentation.qml:261
> I have not seen your code yet, I will check tomorrow. Probably because you 
> have something like this:
> 
>   Layout.preferredWidth: parent.width / 2
>   Layout.preferredHeight: parent.height / 2
> 
> Check the last answer from: How to design a multi-level fluid layout in QML 
> <https://stackoverflow.com/questions/30604751/how-to-design-a-multi-level-fluid-layout-in-qml>.
>  In short words: when possible, do not use Layout.preferredWidth, prefer 
> implicitWidth instead. If you want to have 50-50 ratio between items, set 
> implicitWidth in both items to the same value.

This advice doesn't seem to be applicable here, as the `implicitWidth` of the 
ColumnLayout child isn't able to be mutated due to the fact that all of its 
child items (text) have fixed `implicitWidth`s.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27160

To: cblack, #vdg, #plasma, manueljlin, ngraham
Cc: kmaterka, iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, 
manueljlin, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to