ngraham added inline comments.

INLINE COMMENTS

> main.qml:59
> +
> +            ColumnLayout {
> +                QQC2.CheckBox {

Instead adding these new layouts, you could just set the following on each 
checkbox that needs to be indented:

  Layout.leftMargin: !LayoutMirroring.enabled ? Kirigami.Units.largeSpacing : 0
  Layout.rightMargin: LayoutMirroring.enabled ? Kirigami.Units.largeSpacing : 0

IMO that's a bit cleaner.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28024

To: bruns, #baloo, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to