broulik added a comment.
Nice job INLINE COMMENTS > abstracttasksmodel.h:99 > LastActivated, /**< The timestamp of the last time a task was the > active task. */ > + ApplicationMenuServiceName, /**< The DBus service name for the > application's menu. > + May be empty. */ `@since 5.19` > xwindowtasksmodel.cpp:25 > #include "xwindowsystemeventbatcher.h" > +#include <config-X11.h> > Unused > xwindowtasksmodel.cpp:48 > > +#include "xcb/xcb.h" > + Unused > xwindowtasksmodel.cpp:473 > +// returns QPair<Service Name, Object Path> for WId window > +QPair<QString, QString> XWindowTasksModel::Private::appMenu(WId window) > +{ I think this should be split into two dedicated methods to match the rest REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27959 To: cblack, #plasma Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart